Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from boolean to dateTime for verified field #177

Closed
Konafets opened this issue May 9, 2018 · 0 comments
Closed

Switch from boolean to dateTime for verified field #177

Konafets opened this issue May 9, 2018 · 0 comments
Labels
enhancement

Comments

@Konafets
Copy link
Contributor

Konafets commented May 9, 2018

Currently the verified field is a boolean type and does just say, that a user has been verified or not. Imagine to change the type to dateTime or add a new field verified_at.

With this simple change we have the information when the user has been verified. The check if the user is verified would be changed to return is_null($this->verified_at).
Konafets added a commit to Konafets/laravel-user-verification that referenced this issue May 9, 2018
@Konafets
Introduce new field verified_at.
f2a2ce7 
The new field will be added next to the current field `verified`, which stores the information if a user has
been verified its email address. Internally the new field is used for verification by check the field against `null`.

The new field makes it possible to not only store _if_ a user has been verified but also _when_.

Closes jrean#177
@Konafets Konafets mentioned this issue May 9, 2018
Closed
@jrean jrean closed this as completed May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce new field verified_at. Konafets/laravel-user-verification
2 participants
@Konafets @jrean