feat: Add defined() validation to mix #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjJunior
approved these changes
Sep 25, 2019
a6662aa
to
c67302f
Compare
hjJunior
approved these changes
Sep 25, 2019
nolleto
approved these changes
Sep 25, 2019
renanbona
approved these changes
Sep 25, 2019
jquense
approved these changes
Sep 25, 2019
src/mixed.js
Outdated
| name: 'defined', | ||
| exclusive: true, | ||
| test(value) { | ||
| return this.schema._isDefined(value); |
There was a problem hiding this comment.
I don't think we need the indirection here, since it's unlikely anyone will override this. Let's just do the check here?
There was a problem hiding this comment.
Sure, gonna do it!
Also, do you think I should implement a version of it for arrays as well? I ask it based in this comment #189 (comment)
There was a problem hiding this comment.
@jquense @talyssonoc - Yes please for arrays - I exactly need this.
There was a problem hiding this comment.
^Wait - does this need more work for arrays? Seems to be working fine for me.
c67302f
to
a3c3dd6
Compare
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After seeing this comment #153 (comment) in an issue about the error when mixing
requiredwithnullableI thought it would be nice to have this validation.