Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: noUnknown() overriding #452

Merged
merged 1 commit into from
Feb 7, 2019
Merged

fix: noUnknown() overriding #452

merged 1 commit into from
Feb 7, 2019

Conversation

vonagam
Copy link
Contributor

@vonagam vonagam commented Feb 7, 2019

Right now noUnknown() changes _options.stripUnknown only when noAllow is true. So when noAllow is false in override the option still remains true.

@jquense jquense merged commit 3047b33 into jquense:master Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vonagam @jquense