sniff: can now sniff snappy-compressed files - on the local file system and on URLs
#925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warning: this argument is passed by value, but not consumed in the function body
--> src/cmd/sniff.rs:512:33
|
512 | fn decompress_snappy_file(path: String, tmpdir: &self_update::TempDir) -> Result<String, CliError> {
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value
= note: `-W clippy::needless-pass-by-value` implied by `-W clippy::pedantic`
help: consider changing the type to
|
512 | fn decompress_snappy_file(path: &str, tmpdir: &self_update::TempDir) -> Result<String, CliError> {
| ~~~~
help: change `path.clone()` to
|
513 | let mut snappy_file = std::fs::File::open(path.to_string())?;
warning: unnecessary use of `to_string`
--> src/cmd/sniff.rs:512:47
|
512 | let mut snappy_file = std::fs::File::open(path.to_string())?;
| ^^^^^^^^^^^^^^^^ help: use: `path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned
= note: `#[warn(clippy::unnecessary_to_owned)]` on by default
warning: deref on an immutable reference
--> src/cmd/sniff.rs:514:31
|
514 | let file_stem = Path::new(&*path).file_stem().unwrap().to_str().unwrap();
| ^^^^^^ help: if you would like to reborrow, try removing `&*`: `path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
= note: `#[warn(clippy::borrow_deref_ref)]` on by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.