Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add tests for 100.dathere.com/lessons/1 #1876

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Conversation

rzmk
Copy link
Collaborator

@rzmk rzmk commented Jun 14, 2024

Lesson 1: Displaying file content with qsv table

Lesson link: https://100.dathere.com/lessons/1

  • Add tests/test_100/lesson_1.rs
  • Rename tests/test_100/exercise_* to tests/test_100/lesson_* and update tests/test_100.rs to reflect changes
  • Update links to lessons (no longer ending with /notes.html)

qsv-test-100-demo-lesson-1

- Add `tests/test_100/lesson_1.rs`
- Rename `tests/test_100/exercise_*` to `tests/test_100/lesson_*` and update `tests/test_100.rs` to reflect changes
- Update links to lessons
@rzmk rzmk changed the title tests: add tests for https://100.dathere.com/lessons/1 tests: add tests for 100.dathere.com/lessons/1 Jun 14, 2024
@rzmk
Copy link
Collaborator Author

rzmk commented Jun 14, 2024

@jqnatividad Looking at maindp.rs and qsvdp --list there's no qsv table command. Is this intended?

If so I can add the macro #[cfg(not(feature = "datapusher_plus"))] for when I use the qsv table command in tests.

@rzmk
Copy link
Collaborator Author

rzmk commented Jun 14, 2024

Looks like the same for qsv fmt too.

@jqnatividad
Copy link
Owner

jqnatividad commented Jun 14, 2024 via email

@jqnatividad jqnatividad merged commit 8d20710 into master Jun 14, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants