stats: add --cache-threshold autoindex creation/deletion logic
#1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- now supports `-c` shortcut - added ability to specify a negative arg. When doing so, if input file size is > abs of negative arg in bytes, an index is automatically created (as it greatly accelerates stats) AND forces caching
Added addl logic to remove auto-created index if the `--cache-threshold` arg ends with a 5.
jqnatividad
changed the title
stats: add --cache-threshold "negative" logicstats: add --cache-threshold autoindex creation/deletion logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
statsruns much faster with an index as it enables multithreading, when--cache-thresholdis negative, it enables autoindex creation when the input's size is greater than the absolute value of the--cache-thresholdargument in bytes.However, some users may not want the index file to hang around after computing stats, so when the
--cache-thresholdnegative arg ends with a 5,statsnow also auto-deletes the index file it auto-created.