Try postgres reconnect on database connection lost #339
Conversation
… to connection error
…ostgres_reconnect # Conflicts: # be-memcached.c # be-memcached.h
| @@ -182,6 +182,12 @@ int be_pg_getuser(void *handle, const char *username, const char *password, char | |||
|
|
|||
| if (PQresultStatus(res) != PGRES_TUPLES_OK) { | |||
| _log(LOG_DEBUG, "%s\n", PQresultErrorMessage(res)); | |||
| if(PQstatus(conf->conn) == CONNECTION_BAD){ | |||
There was a problem hiding this comment.
What if this was executed prior to running a query - will that still work?
There was a problem hiding this comment.
I am not sure if i understand your comment correctly. How should that be possible at that position ? I understand that all postgres queries are currently performed synchronously. That means that the query has been finished (not sucessfully) when this piece of code comes into play.
On line 174 there is a check if the database connection has been initialized
if (!conf || !conf->userquery || !username || !*username)
return BACKEND_DEFER;
That means a connection should exist a the moment and a query has finished
There was a problem hiding this comment.
I've looked at the source, and you are of course correct.
|
Is there still a reason left why this can't be merged so far ? |
|
I think this is good to go - but I don't have the commit bit. |
|
As @jasiek has reviewed this, I will press the button. Thank you for your work, gentlement! |
This pull request should cause the postgres auth adapter to try to reestablish a connection if a query was rejected because of a bad connection.
I should be a first approach to fix #269 . This could be implemented a lot more suffisticated (e.g., the connection retries could be limited), but this should work for now.