Skip to content
This repository has been archived by the owner on Mar 12, 2019. It is now read-only.

Fixed warnings for this to build cleanly with gcc 7.3.0. #333

Merged
merged 1 commit into from
Mar 4, 2018

Conversation

jasiek
Copy link
Contributor

@jasiek jasiek commented Mar 3, 2018

This fixes the following:

cc  -I/mqtt/mosquitto/src/ -I/mqtt/mosquitto/lib/ -fPIC -Wall -Werror  -DBE_CDB -DBE_POSTGRES -DBE_HTTP -DBE_JWT -DBE_FILES  -Icontrib/tinycdb-0.78// -I`pg_config --includedir` -I/src -DDEBUG=1 -I/mqtt/openssl/include   -c -o be-postgres.o be-postgres.c
be-postgres.c: In function 'addKeyValue':
be-postgres.c:392:25: error: comparison between pointer and zero character constant [-Werror=pointer-compare]
  while (*(keywords + n) != '\0')
                         ^~
be-postgres.c:392:9: note: did you mean to dereference the pointer?
  while (*(keywords + n) != '\0')
         ^
be-postgres.c:404:19: error: comparison between pointer and zero character constant [-Werror=pointer-compare]
  if ((keywords[n] != '\0') || (values[n] != '\0')){
                   ^~
be-postgres.c:404:7: note: did you mean to dereference the pointer?
  if ((keywords[n] != '\0') || (values[n] != '\0')){
       ^
be-postgres.c:404:42: error: comparison between pointer and zero character constant [-Werror=pointer-compare]
  if ((keywords[n] != '\0') || (values[n] != '\0')){
                                          ^~
be-postgres.c:404:32: note: did you mean to dereference the pointer?
  if ((keywords[n] != '\0') || (values[n] != '\0')){
                                ^
cc1: all warnings being treated as errors
<builtin>: recipe for target 'be-postgres.o' failed

@jpmens jpmens merged commit ed0e1a5 into jpmens:master Mar 4, 2018
@jpmens
Copy link
Owner

jpmens commented Mar 4, 2018

Merged, thanks.

@jasiek
Copy link
Contributor Author

jasiek commented Mar 4, 2018

I just realised there must be more of these in the remaining modules. PR in progress.

@jasiek
Copy link
Contributor Author

jasiek commented Mar 4, 2018

Actually - no other warnings were found, except for the memcached backend, which I'm unsure if is entirely operational.

@jpmens
Copy link
Owner

jpmens commented Mar 4, 2018

I don't really think anybody uses that, but if you feel like silencing warnings, please feel free -- I'll accept anyway.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants