Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on newer Node.js versions and extend API #2

Merged
merged 2 commits into from
Jun 9, 2021

Conversation

gerhardberger
Copy link
Contributor

This PR updates the Node.js bindings in the repo so it won't crash on newer versions.

It also adds an extra code field to be returned to the API.

@jmcrthrs
Copy link

jmcrthrs commented Jun 3, 2021

Which Node & Electron versions have you tested this library with?

I've tried with Node 8, 11 & 14, and Electron 9 but get the same response with each:

{ code: 1000, message: 'Error Domain=com.apple.AuthenticationServices.AuthorizationError Code=1000 "(null)"' }

I suspect this isn't the library, but actually an issue with my development setup, such as not having the correct entitlements or capabilities configured.

@gerhardberger
Copy link
Contributor Author

I tried it with electron 12

yes, that issue is due to lack of entitlements

@jmcrthrs
Copy link

jmcrthrs commented Jun 4, 2021

I tried it with electron 12

yes, that issue is due to lack of entitlements

Yes I thought as much. I have added this package to a fresh Electron app, but I can't find any information on how to configure the application to use mac entitlements during development.

The closest information I have found is in the In-App Purchase guide.

To test In-App Purchase in development with Electron you'll have to change the CFBundleIdentifier in node_modules/electron/dist/Electron.app/Contents/Info.plist. You have to replace com.github.electron by the bundle identifier of the application you created with iTunes Connect.

Do I need to create a new XCode project and import the Electron application?

Thanks for any help you can provide.

@gerhardberger
Copy link
Contributor Author

yea I think you have to build a release package of the electron app with correct provisioning profile and sign and notarize it

@jmcrthrs
Copy link

jmcrthrs commented Jun 4, 2021

Ah so that suggests it's not possible to test the sign in with apple during development?

@jpalumickas jpalumickas merged commit ec6154a into jpalumickas:master Jun 9, 2021
@jpalumickas
Copy link
Owner

Thanks @gerhardberger for PR. Released v0.5.0 version. Can you test if it's working now for you ? 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants