Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the StopIteration exception raised in Sqlalchemy ModelView when the primary key is not included in the field list. #482

Merged
merged 3 commits into from
Jan 20, 2024
Merged

Fixed the StopIteration exception raised in Sqlalchemy ModelView when the primary key is not included in the field list. #482

merged 3 commits into from
Jan 20, 2024

Conversation

jowilf
Copy link
Owner

@jowilf jowilf commented Jan 20, 2024 •
edited
Loading

No description provided.

@jowilf jowilf changed the title fix #481 Fixed the StopIteration exception raised in Sqlalchemy ModelView when the primary key is not included in the field list. Jan 20, 2024
@jowilf jowilf changed the title Fixed the StopIteration exception raised in Sqlalchemy ModelView when the primary key is not included in the field list. Fixed the StopIteration exception raised in Sqlalchemy ModelView when the primary key is not included in the fields list. Jan 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 20, 2024 •
edited
Loading

🚀 Deployed on https://docs-preview-482--starlette-admin-docs-preview.netlify.app

@github-actions github-actions bot temporarily deployed to pull request January 20, 2024 23:00 Inactive
@jowilf jowilf changed the title Fixed the StopIteration exception raised in Sqlalchemy ModelView when the primary key is not included in the fields list. Fixed the StopIteration exception raised in Sqlalchemy ModelView when the primary key is not included in the field list. Jan 20, 2024
@github-actions github-actions bot temporarily deployed to pull request January 20, 2024 23:04 Inactive
@codecov Codecov
Copy link

codecov bot commented Jan 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (63948e3) 100.00% compared to head (9231cdf) 100.00%.

❗ Current head 9231cdf differs from pull request most recent head 2279437. Consider uploading reports for the commit 2279437 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #482   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           75        75           
  Lines         5812      5817    +5     
=========================================
+ Hits          5812      5817    +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request January 20, 2024 23:11 Inactive
@jowilf jowilf merged commit 50e19a9 into main Jan 20, 2024
7 checks passed
@jowilf jowilf deleted the fix-481 branch January 20, 2024 23:13
@jowilf jowilf mentioned this pull request Jan 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jowilf