Skip to content

Commit

Permalink
tests for songs and composers
Browse files Browse the repository at this point in the history
  • Loading branch information
jottenlips committed Dec 11, 2019
1 parent 177e710 commit 507ca48
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 6 deletions.
1 change: 0 additions & 1 deletion aws_resources/tests/dynamo_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
from aws_resources.dynamo import build_update_expression, build_update_attributes_dictionary

def test_build_update_expression():

update_exp = build_update_expression(mock_song)
print(update_exp)
assert update_exp == 'set title=:title, chordChart=:chordChart, composer=:composer'
Expand Down
2 changes: 1 addition & 1 deletion features/Composers/composer.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def get_composers(obj, info, last_evaluated_key):
Limit=10,
ExclusiveStartKey={'id': last_evaluated_key},
Select='ALL_ATTRIBUTES',
FilterExpression='attribute_exists(title)'
FilterExpression='attribute_exists(fullName)'
)['Items']
return composers

Expand Down
4 changes: 3 additions & 1 deletion features/Composers/composerTypes.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from ariadne import load_schema_from_path, ObjectType, QueryType, MutationType
from features.Composers.composer import resolve_composer, create_composer, update_composer
from features.Composers.composer import resolve_composer, create_composer, update_composer, get_composers
from features.Songs.song import resolve_songs

composerQueries = QueryType()
Expand All @@ -9,6 +9,8 @@
composerObjectType = ObjectType('FBComposer')
composerObjectType.set_field("songs", resolve_songs)
composerQueries.set_field('getComposer', resolve_composer)
songQueries.set_field('getComposers', get_composers)

composerMutations.set_field('createComposer', create_composer)
composerMutations.set_field('updateComposer', update_composer)

10 changes: 8 additions & 2 deletions features/Composers/tests/test_composer.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

from features.Composers.composer import resolve_composer, create_composer, update_composer
from features.Composers.composer import resolve_composer, create_composer, update_composer, get_composers
from aws_resources.mock_dynamo import setup_mocks, mock_composer, mock_create_composer
from moto import mock_dynamodb2

Expand All @@ -8,7 +8,13 @@ def test_resolve_composer():
setup_mocks()
composer = resolve_composer({}, {}, "c1")
assert composer == mock_composer


@mock_dynamodb2
def test_get_composers():
setup_mocks()
composers = get_composers({}, {}, "")
assert composers == [mock_composer]

@mock_dynamodb2
def test_create_composer():
setup_mocks()
Expand Down
9 changes: 8 additions & 1 deletion features/Songs/tests/test_song.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

from features.Songs.song import resolve_song, resolve_songs, create_song, update_song
from features.Songs.song import resolve_song, resolve_songs, create_song, update_song, get_songs
from aws_resources.mock_dynamo import setup_mocks, mock_song, another_mock_song, mock_create_song
from moto import mock_dynamodb2

Expand All @@ -15,6 +15,13 @@ def test_resolve_song():
songs = list(resolve_songs({'songs': ["1", "2"]}, {}))
assert songs == [mock_song, another_mock_song]


@mock_dynamodb2
def test_get_songs():
setup_mocks()
songs = get_songs({}, {}, "")
assert songs == [mock_song, another_mock_song]

@mock_dynamodb2
def test_create_song():
setup_mocks()
Expand Down

0 comments on commit 507ca48

Please sign in to comment.