Add support for reading stdout/stderr for each test case #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdk
requested changes
Sep 30, 2019
There was a problem hiding this comment.
Thank you for your contribution @rwbergstrom! 🎉
Left some very minor comments, and will be happy to merge afterwards.
Additionally, you mentioned that go-junit was missing properties from your surefire test reports. I went and created #28, as I suspect that this isn't a unique class of problem. Would you mind linking your test XML there? Just so I can collect some real-world examples (that will eventually make their way into a Go test).
Cheers!
thecapdan
pushed a commit
to thecapdan/go-junit
that referenced
this pull request
Dec 28, 2020
thecapdan
pushed a commit
to thecapdan/go-junit
that referenced
this pull request
Dec 28, 2020
goddenrich
pushed a commit
to goddenrich/go-junit
that referenced
this pull request
Dec 30, 2020
Co-authored-by: Ryan Bergstrom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If tests fail, there's frequently additional info the
system-outandsystem-errtags for each test case (at least with surefire test reports). The existing code captures suite-wide stdout/stderr, but misses the per-test-case variant.This just duplicates the logic in order to capture per-test output as well.