Don't set #![deny(warnings)] on the whole crate #1040
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deny(warnings) is generally considered to be a pretty strong anti-pattern0 because new warnings can be introduced, either by new versions of rustc or by new versions of dependencies, that the binary author may want to prevent but shouldn't prevent users from building from source. In this case, a newer version of
chrono
deprecatedNaiveDateTime::from_timestamp
, which ended up breaking my CI pipeline because josh is no longer able to build.Generally, instead, it's better practice to deny specific warnings, or build with
-D warnings
in CI.