Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert axios (1.6.0 to 0.27.2) #651

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

Jocke4f
Copy link
Collaborator

@Jocke4f Jocke4f commented Feb 16, 2024

Reverting axios (update previously made in #607).

In order to step to axios 1.6.0 the change in axios from Common JS to ES Module needs to be handled, this it not quickly done. This revert is only to make a release more sucessfull. A new issue will be created to track this technical debt.

When this PR has been merged to main is the suggestion that we go ahead with a new release since there are several queued up fixes that would be good to have in a formal release package.

Fixes #640

Reverting axios (update previously made in josephdadams#607). In order to step to latest axios (today 1.6.0) the change in axios from Common JS to ES Module in axios needs to be handled. This revert is only to make a release more sucessfull.
@Jocke4f Jocke4f marked this pull request as ready for review February 16, 2024 22:03
@josephdadams josephdadams merged commit 0100c49 into josephdadams:master Feb 17, 2024
11 checks passed
@josephdadams
Copy link
Owner

There is a PR that will be submitted soon that will bring in ember+ support so let’s wait for that one before a new release

@Jocke4f Jocke4f deleted the fix_640_axios_revert branch April 22, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error [ERR_REQUIRE_ESM]
2 participants