Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shut down the application by pressing ctrl + c #12

Merged
merged 2 commits into from
Apr 26, 2020

Conversation

manne
Copy link
Contributor

@manne manne commented Apr 25, 2020

Fixes #11

@manne
Copy link
Contributor Author

manne commented Apr 25, 2020

The test execution is blocked due to the changes 😣

@joro550
Copy link
Owner

joro550 commented Apr 26, 2020

I now see what you mean by the tests are now blocked, because the await is waiting for the ctrl c input from the tests, haha!

Basically we need to tell the server that we don't have to wait for it to complete, we can do this by overriding StartServer method in TestRealServerImpl:

protected override Task StartServer(ISettings settings, CancellationToken cancellationToken)
{
    base.StartServer(settings, cancellationToken);
    return Task.CompletedTask;
}

Would appreciate if you made this change before the merge :)

@manne
Copy link
Contributor Author

manne commented Apr 26, 2020

@joro550 done

@joro550 joro550 merged commit f958f9d into joro550:master Apr 26, 2020
@manne manne deleted the shutdown branch April 26, 2020 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application is not shutting down by pressing ctrl + c
2 participants