Include libxdo.pc in release tarball #345
Conversation
Also drop the "|| true" from the "rm -f" command as likely unneeded.
|
Thanks for the quick fix :) |
|
Hmm, do you know what's up with the tags? v3.20210804.2 points to a commit that's not on any branch and 3.20210804.2 is not an actual release with accompanying tarball. Thanks for doing new releases btw, I use xdotool daily (for simple tasks generally). (Sorry for nitpicking. 🐱) |
|
Correction: The .2 release has the wrong version in libxdo.pc only; `xdotool -v' shows the correct version. Probably not worth bothering with a new release just for the version string in libxdo.pc. :) |
|
Hah, figures I’d miss this. I don’t mind doing another release.
…On Wed, Aug 4, 2021 at 10:12 AM Evangelos Foutras ***@***.***> wrote:
Correction: The .2 release has the wrong version in libxdo.pc only;
`xdotool -v' shows the correct version. Probably not worth bothering with a
new release just for the version string in libxdo.pc. :)
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#345 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABAF2T5CGOZSBXZCU3G6H3T3FYGXANCNFSM5BRNBGRQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
|
To guard against this, the update-version target could be made to regenerate libxdo.pc or you could ship pc.sh in the tarball (and exclude libxdo.pc). Not sure which solution is preferable though (leaning towards keeping libxdo.pc in the tarball). The two tags for .2 are a bit confusing; don't know if this is fixable (or even worth fixing). Seems the one with the |
* Add libxdo.pc and README.md to release tarball * Add libxdo.pc to clean target Also drop the "|| true" from the "rm -f" command as likely unneeded.
make installfails when trying to package v3.20210804.1 becausepc.shis missing.I opted to generate and include libxdo.pc directly instead of shipping
pc.shin the tarball.