Add extern "C" guards #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The year is 2021. All C libraries are _expected_ to wrap their headers with extern "C" so they can be used from C++. It is literally 6 lines and it saves hundreds of frustrating linker errors. Fixes jordansissel#63.
xcfrg
approved these changes
Jun 25, 2021
jordansissel
approved these changes
Jul 6, 2021
|
Thanks for this improvement! I’m sure lots of C++ users will be happy with this change :) |
buldi
pushed a commit
to buldi/xdotool
that referenced
this pull request
Apr 23, 2022
The year is 2021. All C libraries are _expected_ to wrap their headers with extern "C" so they can be used from C++. It is literally 6 lines and it saves hundreds of frustrating linker errors. Fixes jordansissel#63.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The year is 2021. All C libraries are expected to wrap their headers with
extern "C"so they can be used from C++. It is literally 6 lines and it saves hundreds of frustrating linker errors.Fixes #63.