Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] #43708 Alert links system container - a11y #43725

Draft
wants to merge 6 commits into
base: 5.1-dev
Choose a base branch
from

Conversation

hans2103
Copy link
Contributor

Pull Request for Issue #43708 .

Summary of Changes

This PR will adjust the styling of the alert boxes. Overrides are done using css custom properties instead of overriding css attributes.

Testing Instructions

I've used the following html to test alert boxes

<div class="alert" role="alert">
    class="alert"<br/>
    A simple primary alert—check it out! <a href="#" class="btn btn-primary">button</a>
</div>
<div class="alert alert-primary" role="alert">
    class="alert alert-primary"<br/>
    A simple primary alert—check it out! <a href="#" class="btn btn-primary">button</a>
</div>
<div class="alert alert-secondary" role="alert">
    class="alert alert-secondary"<br/>
    A simple secondary alert—check it out! <a href="#" class="btn btn-secondary">button</a>
</div>
<div class="alert alert-success" role="alert">
    class="alert alert-success"<br/>
    A simple success alert—check it out! <a href="#" class="btn btn-success">button</a>
</div>
<div class="alert alert-danger" role="alert">
    class="alert alert-danger"<br/>
    A simple danger alert—check it out! <a href="#" class="btn btn-danger">button</a>
</div>
<div class="alert alert-warning" role="alert">
    class="alert alert-warning"<br/>
    A simple warning alert—check it out! <a href="#" class="btn btn-warning">button</a>
</div>
<div class="alert alert-info" role="alert">
    class="alert alert-info"<br/>
    A simple info alert—check it out! <a href="#" class="btn btn-info">button</a>
</div>
<div class="alert alert-light" role="alert">
    class="alert alert-light"<br/>
    A simple light alert—check it out! <a href="#" class="btn btn-light">button</a>
</div>
<div class="alert alert-dark" role="alert">
    class="alert alert-dark"<br/>
    A simple dark alert—check it out! <a href="#" class="btn btn-dark">button</a>
</div>

Actual result BEFORE applying this Pull Request

Screenshot 2024-06-30 at 20 49 28 Screenshot 2024-06-30 at 20 49 18

Expected result AFTER applying this Pull Request

Screenshot 2024-06-30 at 20 30 24 Screenshot 2024-06-30 at 20 30 13

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Jun 30, 2024
@brianteeman
Copy link
Contributor

Why are you overriding the native bootstrap alert classes. It is doing this sort of thing that causes problems in the first place,

@hans2103
Copy link
Contributor Author

hans2103 commented Jul 1, 2024

Why are you overriding the native bootstrap alert classes. It is doing this sort of thing that causes problems in the first place,

I do agree with you. I am going to refactor .alert and joomlaalert.
Less overrides means less maintenance.

I convert this PR as draft

@hans2103 hans2103 marked this pull request as draft July 1, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants