Update to joomla-cypress 1.1.0

[muhme]

Summary of Changes

Revised after 21 commits on 9 July 2024

The goal is to use the actual NPM joomla-cypress version 1.1.0 for all four active joomla-cms branches. Actual 4.4-dev is using 0.0.16; and 5.1-dev, 5.2-dev and 6.0-dev are using 1.0.3.

• joomla-cypress version is set to ^1.1.0
• The Cypress commands overwritten by System Tests for a faster session-based login have been removed as they are included in joomla-cypress. And the note about overwritten commands in tests/System/README.md is deleted.
• The check for PHP warnings has been reactivated. This led to errors, but all places were fixed by @alikon with down-merging and extendig the System Tests - thank you!

⚠️⚠️⚠️ Only NPM package joomla-cypress was updated with the npm update, BUT there are more changes in package-lock.json. ⚠️⚠️⚠️

• Reason is that package.json and package-lock.json were not synchronised. As one example in package.json the version is stated as '4.4.6' and in package-lock.json as '4.4.4'.

Re-tested on 9 Juli 2024

• after 20 commits
  • on Ubuntu 24.04 LTS Noble Numbat with PHP 8.3.6 and
  • Windows 11 Pro with Laragon and PHP 8.1.10.
• after 21 commits (including lint error fixes)
  • on Intel macOS 14.5 Sonoma with PHP 8.3.8.

Testing Instructions

• Install (in using npm ci) and run System Tests w/o errors
• Check version is 1.1.0 in node_modules/joomla-cypress/package.json
• Check that there were no effects from the additional updates in package-lock.json

Actual result BEFORE applying this Pull Request

• System Tests is using joomla-cypress version 0.0.16 and a custom implementation of the faster session-based login
• No PHP warning checks
• System Tests suite is running without errors

Expected result AFTER applying this Pull Request

• System Tests is using joomla-cypress actual version 1.1.0 and its session-based login
• PHP warning checks are activated again
• System Tests suite is running without errors

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

Up-Merge

⚠️ This PR cannot simply be up-merged. Parts needed from this PR:

• Use joomla-cypress 1.1.0
  • Note: In all other branches, the file package-lock.json is not synchronised with package.json either
  • If it helps I can create PR in the branches with update only joomla-cypress 1.1.0, creating package-lock.json and test on the three OS
• The notice about overwritten Cypress commands must be deleted, as the other branches already used joomla-cypress 1.0.3 before and the commands were not overwritten there -> If it helps I can create PR in the branches
  • 6.0-dev has to be merged first System Tests README extended #43642

[hans2103]

I have tested this item ✅ successfully on 9a66d94

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43722.}

[richard67]

@muhme Which command have you used to update the dependency? To me it seems this PR updates more dependencies than only joomla-cypress and it’s dependencies.

[muhme]

@muhme Which command have you used to update the dependency? To me it seems this PR updates more dependencies than only joomla-cypress and it’s dependencies.

@richard67 npm update to stay up-to-date with all dependencies. Should it changed to only update joomla-cypress and it’s dependencies?

[richard67]

Should it changed to only update joomla-cypress and it’s dependencies?

@muhme Yes. We don’t do dependency updates with patch versions. And to update all dependencies without even mentioning it in the description of this PR would not be good anyway. @laoneo can explain and decide.

[alikon]

the #43726 should avoid the need for the hack in newsfeed and in the related_items module....

[muhme]

Set to DRAFT to:

• Only update joomla-cypress and it’s dependencies
• Remove joomla-cypress commands are overwritten in tests/System/README.md
• Wait for fix for joomla-cypress 1.1.0 muhme/joomla-cms#6
• Test again

[muhme]

And to update all dependencies without even mentioning it in the description of this PR would not be good anyway.

@richard67 Since the creation of this PR, the following statement has been included in the description:

⚠️ All other NPM packages are also updated with the npm update, see differences in package-lock.json.

The fact that all packages are updated is therefore explicitly named from my point of view and even provided with a visual eye-catcher. Also, the following instruction was added to the "Test Instructions" section since this PR was created:

• Check that there were no effects from the updates in the NPM packages.

Could it be that you haven't read the description, or am I the one who's in the wrong movie? 😃

[richard67]

@muhme Seems I need glasses 👓:-) You are right, description is ok, sorry for the noise :-)

[muhme]

Reverted to "Ready to merge", the description has been completely revised after all changes.

[laoneo]

Are the changes in the View classes really needed?

[muhme]

Are the changes in the View classes really needed?

In 4.4-dev with joomla-cypress 0.0.16 the PHP message and warningas checks were disabled. With joomla-cypress 1.1.0 they are enabled and the System tests had 6 failures. At first there were workaround 'hacks' in the system tests to get the test suite running without errors. @alikon solved all system test 'hacks' by backporting and investigating. @alikon: Can you explain more in detail?

[laoneo]

If these are bugs in the code, we should do them separate and then they need also two human tests.

[brianteeman]

Golden rule - solve one issue with one pull request