Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.2] [PHP8.4] Update for nullable type declaration #43323

Open
wants to merge 14 commits into
base: 5.2-dev
Choose a base branch
from
Open

[5.2] [PHP8.4] Update for nullable type declaration #43323

wants to merge 14 commits into from
+859 −857

Conversation

heelc29
Copy link
Contributor

@heelc29 heelc29 commented Apr 20, 2024 •
edited
Loading

Summary of Changes

updates for https://wiki.php.net/rfc/deprecate-implicitly-nullable-types

Testing Instructions

at the moment no QA release of PHP8.4 ... so only code review (and phpcs by drone) PHP 8.4.0 Alpha 1 available for testing

Actual result BEFORE applying this Pull Request

Warning:

Deprecated: Joomla\CMS\Application\AdministratorApplication::__construct(): Implicitly marking parameter $input as nullable is deprecated, the explicit nullable type must be used instead in libraries\src\Application\AdministratorApplication.php on line 74

Deprecated: Joomla\CMS\Application\AdministratorApplication::__construct(): Implicitly marking parameter $config as nullable is deprecated, the explicit nullable type must be used instead in libraries\src\Application\AdministratorApplication.php on line 74

Deprecated: Joomla\CMS\Application\AdministratorApplication::__construct(): Implicitly marking parameter $client as nullable is deprecated, the explicit nullable type must be used instead in libraries\src\Application\AdministratorApplication.php on line 74

Deprecated: Joomla\CMS\Application\AdministratorApplication::__construct(): Implicitly marking parameter $container as nullable is deprecated, the explicit nullable type must be used instead in libraries\src\Application\AdministratorApplication.php on line 74

[...]

Expected result AFTER applying this Pull Request

No new deprecated warnings (excepted composer dependencies) if update to PHP8.4

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@HLeithner HLeithner changed the base branch from 5.1-dev to 5.2-dev April 24, 2024 09:06
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.2-dev.

@HLeithner HLeithner changed the title [5.1][PHP8.4][WIP] Update for nullable type declaration [5.2] [PHP8.4][WIP] Update for nullable type declaration Apr 24, 2024
@heelc29 heelc29 changed the title [5.2] [PHP8.4][WIP] Update for nullable type declaration [5.2] [PHP8.4] Update for nullable type declaration Apr 25, 2024
@heelc29 heelc29 marked this pull request as ready for review April 25, 2024 19:17
@heelc29 heelc29 force-pushed the 5.1/php84/implicitly-nullable-parameter branch from 74dad8b to 02fe995 Compare June 30, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bembelimen bembelimen Awaiting requested review from bembelimen bembelimen is a code owner

@HLeithner HLeithner Awaiting requested review from HLeithner HLeithner is a code owner

@rdeutz rdeutz Awaiting requested review from rdeutz rdeutz is a code owner

@zero-24 zero-24 Awaiting requested review from zero-24

Assignees
No one assigned
Labels
Feature PR-5.2-dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@heelc29 @HLeithner @Hackwar @joomla-cms-bot