Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #89

Merged
merged 4 commits into from
Jun 5, 2018
Merged

Spelling #89

merged 4 commits into from
Jun 5, 2018

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Jun 5, 2018

Generated by https://github.com/jsoref/spelling f; to maintain your repo, please consider fchurn

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.244% when pulling 1da86db on jsoref:spelling into 4646e7f on joohoi:master.

@joohoi
Copy link
Owner

joohoi commented Jun 5, 2018

Thanks for the PR! The tool looks really good too. I didn't have the time to go through all of the options, but I'll definately (intended typo, as it's one of the words I tend to write wrong all the time) will be using this in the future. I wonder if there's a suggested way to automate all this in Travis job for example, but I'll create an feature request issue in your repo regarding this.

@jsoref
Copy link
Contributor Author

jsoref commented Jun 5, 2018

@joohoi https://github.com/checkstyle/checkstyle/blob/master/.ci/test-spelling-unknown-words.sh is what I did for the checkstyle project. I've been meaning to offer it to other projects.

@joohoi
Copy link
Owner

joohoi commented Jun 5, 2018

I'll check it out later on, thanks!

Copy link
Owner

@joohoi joohoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@@ -40,7 +40,7 @@ Using acme-dns is a three-step process (provided you already have the self-hoste

The method returns a new unique subdomain and credentials needed to update your record.
Fulldomain is where you can point your own `_acme-challenge` subdomain CNAME record to.
With the credentials, you can update the TXT response in the service to match the challenge token, later referred as \_\_\_validation\_token\_recieved\_from\_the\_ca\_\_\_, given out by the Certificate Authority.
With the credentials, you can update the TXT response in the service to match the challenge token, later referred as \_\_\_validation\_token\_received\_from\_the\_ca\_\_\_, given out by the Certificate Authority.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun fact: #66 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You aren't alone: ossec/ossec-docs@1b447f0 (and following)

@joohoi joohoi merged commit fbd5c65 into joohoi:master Jun 5, 2018
@jsoref jsoref deleted the spelling branch June 5, 2018 08:43
jacobmyers-codeninja pushed a commit to jacobmyers-codeninja/acme-dns that referenced this pull request Sep 30, 2020
* spelling: the challenging

* spelling: effects

* spelling: received

* spelling: vagrantfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants