Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return cname if requested RR was not found and cname exists (fixes #48) #49

Merged
merged 1 commit into from
Mar 13, 2018
Merged

return cname if requested RR was not found and cname exists (fixes #48) #49

merged 1 commit into from
Mar 13, 2018

Conversation

Yannik
Copy link
Contributor

@Yannik Yannik commented Mar 2, 2018

No description provided.

@coveralls
Copy link

coveralls commented Mar 2, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 92.411% when pulling 4d214d7 on Yannik:patch-1 into 9a908d7 on joohoi:master.

@Yannik
Copy link
Contributor Author

Yannik commented Mar 2, 2018 •
edited
Loading

For

records = [ 
    "acme-dns.mydomain.org. CNAME hostname.mydomain.org",
]

this correctly returns acme-dns.mydomain.org. 3600 IN CNAME hostname.mydomain.org. instead of NXDOMAIN.

@joohoi
Copy link
Owner

joohoi commented Mar 13, 2018

Thanks for the PR, and sorry it took so long to get around it.

@joohoi joohoi merged commit 978ac5d into joohoi:master Mar 13, 2018
jacobmyers-codeninja pushed a commit to jacobmyers-codeninja/acme-dns that referenced this pull request Sep 30, 2020
@joohoi
Merge pull request joohoi#49 from Yannik/patch-1
3cde554 
return cname if requested RR was not found and cname exists (fixes joohoi#48)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Yannik @coveralls @joohoi