Refactoring #327
Refactoring #327
Conversation
There was a problem hiding this comment.
Looks good, the only thing I'm a bit unsure of is committing IDE configs to a repo. Seeing that it is merely a go language server configuration, it might be ok but I wonder if this was intentional?
Also sorry about the merge conflicts, I added a small fix to remove one dangling reference to the old logging package that was in use.
Yep. Thats intentional, so vs code formats the files correctly on saving. Otherwise the default settings would be applied and the imports would be sorted in the default order. I prefer to group local packages. |
recurring linter checks don't make that much sense. The code & linter checks should not change on their own over night ;)
This reverts commit 30250bf.
d2cd308
to
dd73feb
Compare
* chore: enable more linters and fix linter issues * ci: enable linter checks on all branches and disable recurring checks recurring linter checks don't make that much sense. The code & linter checks should not change on their own over night ;) * chore: update packages * Revert "chore: update packages" This reverts commit 30250bf. * chore: manually upgrade some packages
I prefer to enable some more linters ;)