Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: Use https URLs for API testing #230

Merged
merged 1 commit into from
Jan 11, 2021
Merged

README: Use https URLs for API testing #230

merged 1 commit into from
Jan 11, 2021

Conversation

DigitalBrains1
Copy link
Contributor

The examples in Testing It Out use http, but in reality one would use https. Consistency helps ease of understanding for the newcomer.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.559% when pulling ba51d77 on DigitalBrains1:httpsdoc into 19069f5 on joohoi:master.

@joohoi
Copy link
Owner

joohoi commented Jan 11, 2021

Oh wow, nice catch! LGTM :)

@joohoi joohoi merged commit d573f77 into joohoi:master Jan 11, 2021
@DigitalBrains1 DigitalBrains1 deleted the httpsdoc branch January 11, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DigitalBrains1 @coveralls @joohoi