Migrate over to certmagic from using autocert #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 20, 2019
jacobmyers-codeninja
pushed a commit
to jacobmyers-codeninja/acme-dns
that referenced
this pull request
Sep 30, 2020
* Use certmagic for challenge validation * WIP * Get the correct key * Override preflight check logic * Fix logging for imported packages and tidy config.cfg * Fix test and add docstrings * Update README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the autocert package that was used for the HTTP api certificate handling with certmagic.
In addition to this, it changes the HTTP api certificate validation over to DNS challenge, which a acme-dns instance should always be able to fulfill, if it's not misconfigured in a way that would make it incapable of handling the issuance for its clients as well.
In broader sense, this means that acme-dns is finally able to acquire and configure HTTPS correctly regardless of being deployed without publicly accessible HTTP API.