-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added http health check endpoint. #137
Added http health check endpoint. #137
Conversation
My test passed, but TestUpdateAllowedFromIP failed. Any idea why? |
Weird indeed. Checking it out now. |
Ok, so there was a bug in the failing test. The previous order that the tests were run ensured that the failing test had a non-default state for For the scope of this PR, it looks great! Thanks! The only modification I'd like to see would be ensuring returning HTTP status
|
Oh, and if you could add a note under "Unreleased" in Changelog about the change. |
Like this?
|
Thanks for your work! LGTM, and merging when the test runs finish! |
* Added http health check endpoint. * Fixed performing POST on GET endpoint. * Explicitly return http status 200 in health check endpoint. * Updated changelog.
Added: