Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hooks support #25

Closed
wants to merge 9 commits into from
Closed

Added hooks support #25

wants to merge 9 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 25, 2018

Added support for hooks, meaning custom handlers can be added for passed values.

@tunnckoCore
Copy link
Contributor

I'm not sure that I like it that way. More clear and safe is how it was in the first commits with the .register thingy.

@ghost
Copy link
Author

ghost commented Sep 26, 2018

I couldn't get the register thingy to work - it was playing hell with the tests, ill have a look again l8r

@ghost
Copy link
Author

ghost commented Oct 2, 2018

Just gimme a touch more time before closing this 👍

@tunnckoCore
Copy link
Contributor

Hey @jonschlinkert @doowb check out this one ;p

@ghost
Copy link
Author

ghost commented Oct 6, 2018

Check out the latest commit @jonschlinkert @tunnckoCore

@ghost
Copy link
Author

ghost commented Oct 9, 2018

Hello?

@ghost
Copy link
Author

ghost commented Oct 12, 2018

Welp, it's there if anyone wants to pull this.

@ghost
Copy link
Author

ghost commented Oct 17, 2018

@tunnckoCore Is anyone going to actually answer this - instead of reacting like an idiot?

@ghost
Copy link
Author

ghost commented Oct 17, 2018

I'd like to see some decisiveness here.

@tunnckoCore
Copy link
Contributor

tunnckoCore commented Oct 18, 2018

Don't push so hard. It's open source dude. I know it may sucks in such situations, but patience is the key. I glace looked over the commits before week and as i remember it's okey to me. I don't have any access to merge, publish, release and proceed. I don't know what's expected from me to do man - don't overreact - i can't do anything anyway.

If you are in hurry you still can fork and use the fork temporary.

@ghost ghost closed this Oct 19, 2018
@ghost
Copy link
Author

ghost commented Oct 19, 2018

nah knock it on the head then mate, thanks

@tunnckoCore
Copy link
Contributor

...

@ghost
Copy link
Author

ghost commented Oct 19, 2018

nah if the owner cant even put a comment, after spending time to react to MOST comments, then it aint worth my time. good luck.

@jonschlinkert
Copy link
Owner

I didn't comment because I was busy widdling down the 140 other issues I had queued up before this one. This was a feature request, not a bug.

@tunnckoCore
Copy link
Contributor

Then you definitely are not familiar with the community and how everything goes.
When I started and didn't have too much to do and I expected quick responses too.
I was excited and was refreshing like per 20-30 minutes - no results, and I was sad and was kinda angry and wondering what the heck is happening, is there something wrong and etc. But eventually, a few years passed and now I have tons of work to do so all this time is passing very fast.

I feel you, really, it still sucks to me too, because I have tons of issues and PRs opened out there without any response or progress. But from time to time I'm pinging and move on.

Not to mention that they are totally different things - reacting is a lot easier than writing meaningful review or comment. :D Anyway.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants