Explicitly check whether console is defined to prevent IE7 from choking ... #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng on Logger.useDefaults()
|
Cheers 👍 |
jonnyreeves
added a commit
that referenced
this pull request
Sep 3, 2014
Explicitly check whether console is defined to prevent IE7 from choking ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...on Logger.useDefaults()
When IE7 encounters a reference to an undefined variable, it simply stops evaluating the JavaScript file and excludes it from the page without providing an error message, which prevents any JavaScript file that calls Logger.useDefaults() from being used on IE7. This change makes useDefaults() do nothing without failing when called on IE7.