Rework the META file to make indexable by Pinto #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinto has trouble indexing this package because it doesn't understand the use of the META.yml in the provides clause of the META info. The spec also allows referring to the file that generates the package in that statement, but pinto (apparently following PAUSE's lead) doesn't consider ReadKey_pm.PL to be a "simile" for that package, the rule seems to be that ".pm.PL" is the acceptable form. This commit - renames ReadKey_pm.PL -> ReadKey.pm.PL; - touches up the Makefile.PL and MANIFEST; and - changes the META.yml file to refer to ReadKey.pm.PL See jonathanstowe#29 and thaljef/Pinto/#241.
|
ps. This might also fix the fact that metacpan.org returns
|
|
While META.yml is a valid target according to CPAN::Meta::Spec there is no reason not to point at the actual file generating the source code, as that's what this field is supposed to be for. |
|
Thanks, |
|
I've just uploaded 2.38 to PAUSE which contains this fix. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinto has trouble indexing this package because it doesn't understand
the use of the META.yml in the provides clause of the META info.
The spec also allows referring to the file that generates the package
in that statement, but pinto (apparently following PAUSE's lead)
doesn't consider ReadKey_pm.PL to be a "simile" for that package, the
rule seems to be that ".pm.PL" is the acceptable form.
This commit
See #29 and thaljef/Pinto#241.