Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W32: Fix ReadKey with argument in the range 0 < x < 1. #26

Merged
merged 1 commit into from
Apr 10, 2017

Conversation

amba
Copy link
Contributor

@amba amba commented Apr 10, 2017

Fix bug #25.

Trying this change on a Windows7 VM fixes the problem for me.

The argument was changed from a double to U32 in commit 549f0e6:

-use DWORD everywhere, DWORD==U32, WaitForSingleObject takes integers not
FP numbers for the timeout

But with integers, you cannot properly scale from seconds to milliseconds.

@jonathanstowe
Copy link
Owner

Hmm,
I'll take your word for it that it works on Windows but it doesn't compile on Linux at all https://travis-ci.org/jonathanstowe/TermReadKey/jobs/220661941 - I'll need to take a look at it before I merge.

@amba
Copy link
Contributor Author

amba commented Apr 10, 2017

Fixed.

@jonathanstowe jonathanstowe merged commit 4af1493 into jonathanstowe:master Apr 10, 2017
@jonathanstowe
Copy link
Owner

Thanks. Not really got a schedule for the next release right now, but in the next month or so I'd guess :)

@amba
Copy link
Contributor Author

amba commented Apr 11, 2017

This also fixes ReadKey(-1), which blocked forever with the U32 argument.

Would be great to have this in the next StrawberryPerl.
@kmx: What are your release plans?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants