Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.3.2 breaks kv1 export (Darwin release) #78

Closed
minorgod opened this issue Feb 24, 2022 · 5 comments · Fixed by #85
Closed

0.3.2 breaks kv1 export (Darwin release) #78

minorgod opened this issue Feb 24, 2022 · 5 comments · Fixed by #85

Comments

@minorgod
Copy link

Not sure if this happens on other architectures, but something about 0.3.2 broke export with --engine-type="kv1".
Version 0.3.1 works for me though. Not sure if import is also affected as I'm only using medusa for export at the moment.

@jonasvinther
Copy link
Owner

Hi @minorgod
Can you post the error message you are getting? I don't have a Mac, so it's hard for me to debug this issue.

@minorgod
Copy link
Author

Hi @minorgod Can you post the error message you are getting? I don't have a Mac, so it's hard for me to debug this issue.

Thanks for the speedy reply!
There's no "error" message per se...it just can't find any keys to read...
./medusa export mountname --format="json" --engine-type="kv1"

no keys found using path [/path] on Vault instance [http:https://vault.mydomain.test:8200]
Error: no keys found using path [/path] on Vault instance [http:https://vault.mydomain.test:8200]

Fairly sure it's not an issue with needing any other flags or env vars since the previous version of medusa works fine. Seems like something in that latest commit has broken the path resoution. Maybe something adding or stripping off a slash somewhere it shouldn't? I'm not a golang programmer so it's hard for me to tell just by looking at the code.

@jonasvinther
Copy link
Owner

How does your mountname look? Does it contain special characters like / or something like that?

@mks-sky
Copy link

mks-sky commented Apr 29, 2022

I can confirm having the same issue with 0.3.2 and 0.3.3 on WLS running Ubuntu 20.04 LTS - we've reverted to 0.3.1. The error message with %s = /path is the same regardless of whether medusa export secrets or medusa export secrets/ or medusa export my/secrets - looks like finalPath variable is not being built correctly.

landrew57 added a commit to landrew57/medusa that referenced this issue May 20, 2022
Currently if the API is determined to be kv1 the path is always set to
path, whereas it should be set to the value of the variable passed in.

Closes jonasvinther#78
jonasvinther pushed a commit that referenced this issue May 25, 2022
Currently if the API is determined to be kv1 the path is always set to
path, whereas it should be set to the value of the variable passed in.

Closes #78
@jonasvinther
Copy link
Owner

I have made a new release v0.3.5. Thank you @landrew57 for solving this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants