Skip to content
This repository has been archived by the owner on Jun 16, 2024. It is now read-only.

Allow changing the container command #20

Merged
merged 2 commits into from
Feb 12, 2022
Merged

Allow changing the container command #20

merged 2 commits into from
Feb 12, 2022

Conversation

duck-rh
Copy link
Contributor

@duck-rh duck-rh commented Feb 9, 2022

Fixes #19

@jonasbb
Copy link
Owner

jonasbb commented Feb 9, 2022

Thanks for the PR :)
Disabling the shellcheck warning for that one line is probably fine. I couldn't find a way to have a default array value, otherwise quoting like PODMAN_RUN_ARGS would be possible.

@duck-rh
Copy link
Contributor Author

duck-rh commented Feb 10, 2022

I guess noone would use a command with arguments, so quoting is probably fine. We can change to disabling the check if someone comes with a use case.

@jonasbb
Copy link
Owner

jonasbb commented Feb 10, 2022

The default sleep 999999999 uses an argument. Adding the quotes will break that. I think supressing the warning for that line should be fine. You can add a # shellcheck disable=... with the correct error code before the podman run.

@jonasbb
Copy link
Owner

jonasbb commented Feb 12, 2022

I finished the PR by disabling the shellcheck error. Thank you for providing the PR.

@jonasbb jonasbb merged commit 75b6be5 into jonasbb:master Feb 12, 2022
@duck-rh
Copy link
Contributor Author

duck-rh commented Feb 14, 2022

@jonasbb thanks a lot

@duck-rh duck-rh deleted the configurable_command branch February 14, 2022 06:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow overriding command
2 participants