More ways of obtaining gitlab-runner for container

[TpmKranz]

I'm using gitlab-runner in user mode and can't write to /usr{/local,}/bin, so my binary is stored in ~/bin, which prepare.sh doesn't care to look at.

I've generalized the logic to look at the shell's PATH locations as well and fall back to downloading if that's unsuccessful (about the same as it was before 4364e41).

The uname -m bit needs verification by someone who's more knowledgable than me about the architecture names, but x86_64 has already been verified to work.

[jonasbb]

Hi, thanks, this looks great. I like the tiered approach to look at multiple places.

I only have x86_64 machines, so cannot test the uname code, but somebody can open a PR if it is wrong.

[jonasbb]

Does this need quoting around the subshell? You have it on line 113 but not here.

[JohnVillalovos]

One reason to use shellcheck as part of the CI

https://github.com/koalaman/shellcheck

[jonasbb]

@JohnVillalovos Thanks for the tip. I am aware of shellcheck and use it already. shellcheck didn't report any errors, but I am not sure if that is a false negative or if quoting here really has no effect.

podman-gitlab-runner/prepare.sh

Line 4 in cddcf62

# shellcheck source=base.sh

I look into adding a couple of automatic checks.

[JohnVillalovos]

I look into adding a couple of automatic checks.

Almost always a good idea 👍

[TpmKranz]

They are not needed in bash, but since I've been trying to make a habit of quoting everything in shell scripts, it's likely I've either plain forgotten or was thrown by the quotes inside the subshell.
Anyway, the quotes should've been there, I've tested that they don't interfere with the inner quotes and I'll force-push them right away.

[jonasbb]

Thanks for checking :)