Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draw_text_overflow: fix wrong offsets for multibyte text. #307

Closed
wants to merge 1 commit into from

Conversation

avm
Copy link
Contributor

@avm avm commented Jul 1, 2014

Won't work for surrogate pairs or probably even combining characters, but it's better than strlen() and 'text + offset'.

@jonas
Copy link
Owner

jonas commented Jul 2, 2014

Thanks for catching this.

In the process of integrating this I ended up rewriting it to use the existing UTF8 utilities since the original patch didn't seem fix all my test cases. However, I've kept you as the author.

If you have improvements to the test cases feel free to paste them below or make a new PR.

@jonas jonas closed this Jul 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants