Allow to toggle revision filtering #1173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argv_format() takes two boolean parameters, and the next patch wants to add another one. Add the same bitfield to struct format_context, instead of just the file-filter bit. This is not strictly needed -- we don't read the extra bits -- but this forces us to consistently access it with "& argv_flag_file_filter", also in callees of argv_format().
"tig -- <pathspec>" shows only commits that touch files matching <pathspec>. The command ":toggle file-filter" (bound to %) can be used to toggle this filtering dynamically. "tig <revisions range>" shows only commits in the given range. This patch adds ":toggle rev-filter" (bound to ^) to quickly toggle this filter. There is already ":toggle rev-args" which is meant to disable rev filtering but that does not work because it fails to redraw the view. Also it cannot re-enable filtering. Also ":set rev-args = HEAD" works but doesn't redraw the view either. We should fix that (should be easy but I didn't check yet), and make ":toggle rev-args" reversible, then both the rev-filter and file-filter toggles will be obsolete. This feature is particularly useful with a new feature in Tig 2.5.2: when pressing m in the blame view, Tig will show the blamed commit centered in the main view, making it easy to explore adjacent commits. Note that if there are many commits between the blamed commit and HEAD, you'll need to wait a bit after pressing m.
|
Thanks, I found myself several times having to restart tig without revision argument when playing with the blame view, this will be really useful. |
koutcher
pushed a commit
that referenced
this pull request
Jan 7, 2022
"tig -- <pathspec>" shows only commits that touch files matching <pathspec>. The command ":toggle file-filter" (bound to %) can be used to toggle this filtering dynamically. "tig <revisions range>" shows only commits in the given range. This patch adds ":toggle rev-filter" (bound to ^) to quickly toggle this filter. This feature is particularly useful with a new feature in Tig 2.5.2: when pressing m in the blame view, Tig will show the blamed commit centered in the main view, making it easy to explore adjacent commits. Note that if there are many commits between the blamed commit and HEAD, you'll need to wait a bit after pressing m. [tk: fixed tab in manual.adoc and tweaked the log message]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.