report() *after* toggling an option and redrawing the view #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This appears to be no longer necessary, and a hold over from when updates were more verbose at the start of and during processing and needed to be cleared when finished (refer to f97f401). More importantly, the call to report_clear() when the view is done updating can hide status messages from the beginning of the update which should remain visible past the end (until some other action clears the status line).
This ensures that the report is remains visible in all cases, rather than immediately being cleared in some cases. In particular, toggling the diff whitespace behaviour (with W) no longer leaves you unsure of the current state.
|
Thanks for finally fixing this. I made a few changes to keep the code closer to what was already there. Also, string_copy() requires a 'static' string (that sizeof() will work on), which it was not the case for "Enabling"/"Disabling" an option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the
report()of atoggle_option()call can be immediately hidden by a view redraw/reload. This primarily annoyed me when toggling diff whitespace behaviour, as I often lost track of which of the four states I was in.