blaming parent uses wrong filename when in subdir #70
Comments
|
Yes, verified. |
jonas
pushed a commit
that referenced
this issue
Aug 10, 2012
When running "tig blame" from within a subdirectory of a repository, the "B" and "," commands will fail with "No blame exist for...". The problem is that the current directory name gets prepended to the filename if view->prev == NULL, but it should not be in this case. Steps to reproduce: 1) checkout a copy of tig 2) cd contrib 3) run "tig blame tig-completion.bash" 4) press B 5) observe "tig: No blame exist for contrib/contrib/tig-completion.bash" Also fixes another minor bug in an expression. Signed-off-by: Jonas Fonseca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If tig is started in a subdirectory of the project, doing
tig blame foo.cwill work just fine, readingsubdir/foo.c. But when using REQ_PARENT to re-blame starting at the parent, tig pulls the filename from git's blame output, which has the full pathname. As a result, we end up trying to blamesubdir/subdir/foo.c.You can replicate easily in tig with:
$ cd contrib $ tig blame release.shand then using
,to blame the parent of any modified line (e.g., the copyright line near the top). Tig will die withtig: No blame exist for contrib/contrib/release.sh.The text was updated successfully, but these errors were encountered: