Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Arabic translation #63

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

OmElDonia
Copy link

Several improvements to appeal to newcomers to the Fediverse and mainstream Arabic speakers.

An easier to pronounce split of "Fediverse".
Translation of email and centralized social media services.
An easier to pronounce split of "Fediverse".
Some improvements to align to mainstream Arabic.
An easier to pronounce split of "Fediverse".
Translation of centralized social media services.
Improvements to translation consistency.
An easier to pronounce split of "Fediverse".
Improvements to translation consistency.
Improvements to align to mainstream Arabic.
@stefanbohacek
Copy link
Member

stefanbohacek commented Aug 8, 2023

Thank you @OmElDonia! Feel free to also add your information in translations/ar/ar.json.

@hoteit Would you mind having a quick look at this when you have some time?

@hoteit
Copy link
Contributor

hoteit commented Aug 8, 2023 via email

Copy link
Contributor

@hoteit hoteit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am reviewing the changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert the change for this file. Please keep the original translation for line 2. It is consistent with the other translations.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is ok.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the intent that it is easier to split the word Fediverse in Arabic as Fedi Verse. However, it is inconsistent with all other translations and it is only one word. Moreover, the majority of the apps (Outlook, Yahoo, Twitter, Instagram, TikTok) are commonly referenced in English. I checked the Arabic translations of the sites and they still kept them in English. I suggest we do not make changes to this file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you only adjust the words in line 8 and line 11 from عبرالفديفيرس to عبر الفديفيرس. The rest of the words need to stay the same (الهاشتاغ and الفديفيرس)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch on line 6 from الخادمس to خادم
the other part of line 6 قم بتشغيل الخادم الخاص بك cannot be replaced by قم بإنشاء الخادم الخاص بك. because we are not creating a server but setting up a server. The rest of the changes need to be reverted to keep Fediverse as one word. Same for Mastodon.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the file needs to be reverted to keep Fediverse as one word rather than two.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 3 إنضم instead of الإنضمام is ok and is much better.
line 5 cannot be changed and needs to be reverted. it is not consistent with the rest of the translations.

Copy link
Contributor

@hoteit hoteit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @OmElDonia for helping in the Arabic translations. I understand your intent to make the word Fediverse simpler to pronounce by splitting the word into two. We had a lot of debates previously on Mastodon around the topic of translating the word. We agreed to keep it the same way it is. It remains consistent with the rest of the translations.
As for transliterating the email providers Hotmail, Gmail, Yahoo etc to Arabic, same for Twitter, instagram, and TikTok , it is not recommended. I checked such providers and none of them did that. I suggest we keep them as is.
If you can please review the comments that I placed on each file.
Also happy to chat with you to discuss them.

@hoteit
Copy link
Contributor

hoteit commented Aug 9, 2023

@stefanbohacek , I appreciate @OmElDonia helping with the translations. I sent back feedback on the changes. I do not recommend merging the code at this point. If @OmElDonia has no time to alters the changes in the pull request or would be prefer that we discuss it, I am happy to do that first.

@stefanbohacek
Copy link
Member

Thank you both, I appreciate all the effort that goes into translating the site!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants