Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix some typo #1

Merged
merged 2 commits into from
May 27, 2019
Merged

docs: Fix some typo #1

merged 2 commits into from
May 27, 2019

Conversation

iliul
Copy link
Contributor

@iliul iliul commented May 22, 2019

No description provided.

@iliul
doc: Fix some typo
eb00ee3 
Signed-off-by: Lei Liu <[email protected]>
@johnzeng
Copy link
Owner

Thanks for fixing typo, but I can't accept this because of the renaming. The file name must strictly match the original file name on https://rocksdb.org.cn/doc.html so they can sync files. Please change them back and then I can merge this PR

@iliul
Copy link
Contributor Author

iliul commented May 22, 2019

The file name must strictly match the original file name on https://rocksdb.org.cn/doc.html so they can sync files.

Agree, will revert this later.

Please change them back and then I can merge this PR

Please keep this open until i remove DNM prefix in pr title 😄

@iliul iliul changed the title docs: Fix some typo DNM: docs: Fix some typo May 22, 2019
johnzeng
johnzeng reviewed May 27, 2019
View reviewed changes
doc/RocksDB-FAQ.md Outdated
@@ -153,7 +153,7 @@
**问:一个迭代器需要持有多少资源，这些资源会在什么时候被释放？**

答：迭代器需要持有数据块以及内存的memtable。每个迭代器需要持有以下资源：
- 当前的迭代器所指向的所有数据块。参考 [迭代器固定的数据块]()
- 当前的迭代器所指向的所有数据块。参考 [迭代器固定的数据块](Memory-usage-in-RocksDB.md#blocks-pinned-by-iterators)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里子标题不对，应该是'迭代器固定的块'，因为我把子标题也翻译了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里子标题不对，应该是'迭代器固定的块'，因为我把子标题也翻译了

Fixed

@johnzeng
Copy link
Owner

Any update?

@iliul iliul changed the title DNM: docs: Fix some typo docs: Fix some typo May 27, 2019
@iliul
Copy link
Contributor Author

iliul commented May 27, 2019

Any update?

链接修复了

最近两天忙，过几天继续学习，感谢你翻译的文档，很有用~

@johnzeng johnzeng merged commit 63a19b4 into johnzeng:master May 27, 2019
@johnzeng
Copy link
Owner

是否需要给你署名？可以加入到校订者名单哈。

@iliul
Copy link
Contributor Author

iliul commented May 27, 2019

是否需要给你署名？可以加入到校订者名单哈。

不用，贡献多了后再考虑吧！

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnzeng johnzeng johnzeng left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iliul @johnzeng