Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSONL output does not properly handle keys with quotes #1425

Merged
merged 5 commits into from
Nov 11, 2023
Merged

JSONL output does not properly handle keys with quotes #1425

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
75c3447
mlr --l2j, --j2l
johnkerl Nov 11, 2023
0749a51
make dev for previous commit
johnkerl Nov 11, 2023
d935553
fix #1424
johnkerl Nov 11, 2023
f29a5db
unit-test cases
johnkerl Nov 11, 2023
53833ba
iterate
johnkerl Nov 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
mlr --l2j, --j2l
  • Loading branch information
@johnkerl
johnkerl committed Nov 11, 2023
commit 75c3447fdbda394e748e0d16adb59f4096609cb1
27 changes: 27 additions & 0 deletions pkg/cli/option_parse.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1680,6 +1680,21 @@ var FormatConversionKeystrokeSaverFlagSection = FlagSection{
*pargi += 1
},
},
{
name: "--j2l",
help: "Use JSON for input, JSONL for output.",
// For format-conversion keystroke-savers, a matrix is plenty -- we don't
// need to print a tedious 60-line list.
suppressFlagEnumeration: true,
parser: func(args []string, argc int, pargi *int, options *TOptions) {
options.ReaderOptions.InputFileFormat = "json"
options.WriterOptions.OutputFileFormat = "json"
options.WriterOptions.WrapJSONOutputInOuterList = false
options.WriterOptions.JSONOutputMultiline = false
*pargi += 1
},
},

{
name: "--j2t",
help: "Use JSON for input, TSV for output.",
Expand Down Expand Up @@ -1803,6 +1818,18 @@ var FormatConversionKeystrokeSaverFlagSection = FlagSection{
*pargi += 1
},
},
{
name: "--l2j",
help: "Use JSONL for input, JSON for output.",
// For format-conversion keystroke-savers, a matrix is plenty -- we don't
// need to print a tedious 60-line list.
suppressFlagEnumeration: true,
parser: func(args []string, argc int, pargi *int, options *TOptions) {
options.ReaderOptions.InputFileFormat = "json"
options.WriterOptions.OutputFileFormat = "json"
*pargi += 1
},
},
{
name: "--l2n",
help: "Use JSON Lines for input, NIDX for output.",
Expand Down