clearTimeout's params should not be bigint (denoland#2838)

jofrantoba · Aug 30, 2019 · 65fa2b8 · 65fa2b8
1 parent c370f74
commit 65fa2b8
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/js/timers.ts b/js/timers.ts
@@ -262,13 +262,15 @@ function clearTimer(id: number): void {
 }
 
 export function clearTimeout(id: number = 0): void {
+ checkBigInt(id);
  if (id === 0) {
  return;
  }
  clearTimer(id);
 }
 
 export function clearInterval(id: number = 0): void {
+ checkBigInt(id);
  if (id === 0) {
  return;
  }

diff --git a/js/timers_test.ts b/js/timers_test.ts
@@ -259,6 +259,21 @@ test(function setTimeoutShouldThrowWithBigint(): void {
  assertEquals(hasThrown, 2);
 });
 
+test(function clearTimeoutShouldThrowWithBigint(): void {
+ let hasThrown = 0;
+ try {
+ clearTimeout((1n as unknown) as number);
+ hasThrown = 1;
+ } catch (err) {
+ if (err instanceof TypeError) {
+ hasThrown = 2;
+ } else {
+ hasThrown = 3;
+ }
+ }
+ assertEquals(hasThrown, 2);
+});
+
 test(function testFunctionName(): void {
  assertEquals(clearTimeout.name, "clearTimeout");
  assertEquals(clearInterval.name, "clearInterval");