Fix compiler warnings #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! Removing the arrays and exclusively using |
|
To activate Travis CI and CodeCov, just go to https://travis-ci.org/ and https://codecov.io/ and login with your GitHub account. Then on Travis CI you have to activate the wignerSymbols repository but CodeCov will just work out-of-the-box. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code caused several compiler warnings, which I fixed.
I also added more warning levels to the CMake file.
On top of that I specified
-Werrorto prevent the introduction of new warnings.The code can be automatically built and tested on Travis CI.
Code coverage is automatically determined and uploaded to CodeCov.
Optionally you can add these badges to your README.
Those badges of course point to my repo, below is the markdown you'd have to insert for your own.