Skip to content

Commit

Permalink
[4.x] Update missing type declarations (#246)
Browse files Browse the repository at this point in the history
  • Loading branch information
joelbutcher committed Feb 15, 2023
1 parent 5435e5d commit 2860e3d
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 37 deletions.
28 changes: 5 additions & 23 deletions stubs/app/Policies/ConnectedAccountPolicy.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,58 +12,40 @@ class ConnectedAccountPolicy

/**
* Determine whether the user can view any models.
*
* @param \App\Models\User $user
* @return mixed
*/
public function viewAny(User $user)
public function viewAny(User $user): bool
{
return true;
}

/**
* Determine whether the user can view the model.
*
* @param \App\Models\User $user
* @param \App\Models\ConnectedAccount $connectedAccount
* @return mixed
*/
public function view(User $user, ConnectedAccount $connectedAccount)
public function view(User $user, ConnectedAccount $connectedAccount): bool
{
return $user->ownsConnectedAccount($connectedAccount);
}

/**
* Determine whether the user can create models.
*
* @param \App\Models\User $user
* @return mixed
*/
public function create(User $user)
public function create(User $user): bool
{
return true;
}

/**
* Determine whether the user can update the model.
*
* @param \App\Models\User $user
* @param \App\Models\ConnectedAccount $connectedAccount
* @return mixed
*/
public function update(User $user, ConnectedAccount $connectedAccount)
public function update(User $user, ConnectedAccount $connectedAccount): bool
{
return $user->ownsConnectedAccount($connectedAccount);
}

/**
* Determine whether the user can delete the model.
*
* @param \App\Models\User $user
* @param \App\Models\ConnectedAccount $connectedAccount
* @return mixed
*/
public function delete(User $user, ConnectedAccount $connectedAccount)
public function delete(User $user, ConnectedAccount $connectedAccount): bool
{
return $user->ownsConnectedAccount($connectedAccount);
}
Expand Down
6 changes: 2 additions & 4 deletions stubs/app/Providers/AuthServiceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,16 @@ class AuthServiceProvider extends ServiceProvider
/**
* The policy mappings for the application.
*
* @var array
* @var array<class-string, class-string>
*/
protected $policies = [
ConnectedAccount::class => ConnectedAccountPolicy::class,
];

/**
* Register any authentication / authorization services.
*
* @return void
*/
public function boot()
public function boot(): void
{
$this->registerPolicies();

Expand Down
8 changes: 2 additions & 6 deletions stubs/app/Providers/SocialstreamServiceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,20 +16,16 @@ class SocialstreamServiceProvider extends ServiceProvider
{
/**
* Register any application services.
*
* @return void
*/
public function register()
public function register(): void
{
//
}

/**
* Bootstrap any application services.
*
* @return void
*/
public function boot()
public function boot(): void
{
Socialstream::resolvesSocialiteUsersUsing(ResolveSocialiteUser::class);
Socialstream::createUsersFromProviderUsing(CreateUserFromProvider::class);
Expand Down
6 changes: 2 additions & 4 deletions stubs/app/Providers/TeamsAuthServiceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class AuthServiceProvider extends ServiceProvider
/**
* The policy mappings for the application.
*
* @var array
* @var array<class-string, class-string>
*/
protected $policies = [
Team::class => TeamPolicy::class,
Expand All @@ -22,10 +22,8 @@ class AuthServiceProvider extends ServiceProvider

/**
* Register any authentication / authorization services.
*
* @return void
*/
public function boot()
public function boot(): void
{
$this->registerPolicies();

Expand Down

0 comments on commit 2860e3d

Please sign in to comment.