Remove asJson from GraphNode

joelbutcher · Dec 19, 2017 · 0673ccd · 0673ccd
1 parent 21e76be
commit 0673ccd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 17 deletions.
diff --git a/src/GraphNode/GraphNode.php b/src/GraphNode/GraphNode.php
@@ -102,18 +102,6 @@ public function asArray()
  }, $this->fields);
  }
 
- /**
- * Get all fields as JSON.
- *
- * @param int $options
- *
- * @return string
- */
- public function asJson($options = 0)
- {
- return json_encode($this->uncastFields(), $options);
- }
-
  /**
  * Get an iterator for the fields.
  *
@@ -184,7 +172,7 @@ public function offsetUnset($key)
  */
  public function __toString()
  {
- return $this->asJson();
+ return json_encode($this->uncastFields());
  }
 
  /**

diff --git a/tests/GraphNode/GraphNodeTest.php b/tests/GraphNode/GraphNodeTest.php
@@ -118,14 +118,14 @@ public function testGettingGraphNodeAsAnArrayWillNotUncastTheDateTimeObject()
  $this->assertInstanceOf(\DateTime::class, $graphNodeAsArray['created_time']);
  }
 
- public function testGettingAGraphNodeAsJSONWillSafelyRepresentDateTimes()
+ public function testGettingAGraphNodeAsAStringWillSafelyRepresentDateTimes()
  {
  $graphNode = new GraphNode([
  'id' => '123',
  'created_time' => '2014-07-15T03:44:53+0000',
  ]);
 
- $graphNodeAsString = $graphNode->asJson();
+ $graphNodeAsString = (string) $graphNode;
 
  $this->assertEquals('{"id":"123","created_time":"2014-07-15T03:44:53+0000"}', $graphNodeAsString);
  }
@@ -186,11 +186,11 @@ public function testAnArrayCanBeInjectedViaTheConstructor()
  $this->assertEquals(['foo', 'bar'], $graphNode->asArray());
  }
 
- public function testACollectionCanBeConvertedToProperJson()
+ public function testAGraphNodeCanBeConvertedToAString()
  {
  $graphNode = new GraphNode(['foo', 'bar', 123]);
 
- $graphNodeAsString = $graphNode->asJson();
+ $graphNodeAsString = (string) $graphNode;
 
  $this->assertEquals('["foo","bar",123]', $graphNodeAsString);
  }