Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tabulate dependency #86

Closed
wants to merge 4 commits into from
Closed

Add tabulate dependency #86

wants to merge 4 commits into from

Conversation

joecummings
Copy link
Owner

No description provided.

@sourcery-ai
Copy link

sourcery-ai bot commented Aug 27, 2021

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 2.33 ⭐ 2.33 ⭐ 0.00
Method Length 45.58 ⭐ 45.58 ⭐ 0.00
Working memory 6.72 🙂 6.72 🙂 0.00
Quality 77.68% 77.68% 0.00%
Other metrics Before After Change
Lines 306 306 0
Changed files Quality Before Quality After Quality Change
gitmine/constants.py 96.02% ⭐ 96.02% ⭐ 0.00%
gitmine/commands/get.py 70.13% 🙂 70.13% 🙂 0.00%
gitmine/models/github_elements.py 87.58% ⭐ 87.58% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gitmine/commands/get.py get_command 4 ⭐ 134 😞 13 😞 55.51% 🙂 Try splitting into smaller methods. Extract out complex expressions
gitmine/commands/get.py get_unassigned_issues 4 ⭐ 180 😞 7 🙂 62.67% 🙂 Try splitting into smaller methods
gitmine/models/github_elements.py GithubElement.from_dict 0 ⭐ 41 ⭐ 10 😞 77.94% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@joecummings joecummings deleted the implement-table-fmt branch August 27, 2021 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant