Skip to content
This repository has been archived by the owner on Jun 27, 2021. It is now read-only.

Added support for events other than click to settings page #32

Merged
merged 2 commits into from
Aug 2, 2018
Merged

Added support for events other than click to settings page #32

merged 2 commits into from
Aug 2, 2018

Conversation

YouKnowBlom
Copy link
Collaborator

Useful for sliders and color pickers. Will require non official plugins to update (simple fix).

A lot of the changes are from doing >reindent lines in vs code

…ll non official plugins to update to the new format)
@rauenzi
Copy link
Collaborator

rauenzi commented Jul 23, 2018

I would personally not approve this change. It opts for forEach which is significantly slower than for loops. As a nitpick indentation should be dictated by the codebase and contributors should match what they are doing not vice versa.

@YouKnowBlom
Copy link
Collaborator Author

YouKnowBlom commented Jul 23, 2018

My bad, didnt know foreach was discouraged😊. Would a rewrite with for instead of foreach be sufficient?

I will update my indentation settings as well, although it seems to only have indented empty lines for some reason.

@YouKnowBlom
Copy link
Collaborator Author

Ill fix the mentioned issues and also try to add some sort of backwards compatibility. Then its up to you @joe27g to merge if you think it's of quality 😄

- Added backwards compatibility to ed_settings plugin event handler
@jakub-studio
Copy link
Contributor

I approve of this change since being restricted to onclick when working with different UI elements such as text inputs ain't great.

@joe27g joe27g merged commit d934926 into joe27g:beta Aug 2, 2018
@joe27g
Copy link
Owner

joe27g commented Aug 2, 2018

I agree with @jakuski, this was something that needed to be done eventually, so why not now :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants