This repository has been archived by the owner on Jun 27, 2021. It is now read-only.
Fix injection for Discord 1.x (Windows) #161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasicoreLord
suggested changes
Mar 12, 2021
installer/EnhancedDiscordUI/Form1.cs
Outdated
| if (is1x) | ||
| { | ||
| // 1.x | ||
| pathPieces = new string[] { basePath, release, "app-" + appVersion, "modules", "discord_desktop_core-1", "discord_desktop_core", "index.js" }; |
There was a problem hiding this comment.
This is where I suggest you change to reflect Discord's module versions, so it doesn't break on most of them. As they update modules more often than the host.
|
@joe27g can you review this? |
|
https://i.imgur.com/WoWblsv.png |
|
@joe27g <@246107833295175681> Close this PR, it won't even work properly on most Discord module updates (just the first one after a host update, due to the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discord 1.x has to be injected into Local AppData instead since the other folder doesn't work anymore. Not sure about macOS/Linux :)