Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve downloading of dust maps #28

Merged
merged 9 commits into from
Mar 7, 2023
Merged

Improve downloading of dust maps #28

merged 9 commits into from
Mar 7, 2023

Conversation

henrysky
Copy link
Contributor

@henrysky henrysky commented Mar 6, 2023

This PR includes:

  • Platform-independent downloads and decompressions by using python standard library
  • Remove downloading options in setup.py
  • Remove the need of specifying DUST_DIR environment variable, either use DUST_DIR if set else ~/.mwdust
  • Download dust maps only when they are first called
  • Remove function to change dustmap folder permission
  • Allowing downloading all dustmaps all at once as well as test remote data file responds without downloading them
  • README and setup.py tweaks

This PR allow platform specific compiled wheels to be used since downloading functions are moved from pre-installation to post-installation.

Copy link
Owner

@jobovy jobovy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Here are some overall comments, I'll probably do another review once these are addressed.

.github/workflows/build.yml Outdated Show resolved Hide resolved
mwdust/DustMap3D.py Outdated Show resolved Hide resolved
mwdust/DustMap3D.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@jobovy
Copy link
Owner

jobovy commented Mar 7, 2023

Okay, I tested this extensively against the previous downloads and everything seems to be working well, so I'll merge this. Thanks again, this is great!

@jobovy jobovy merged commit 804c4df into jobovy:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants