Add check_call_in_cache method to check cache without calling function (as per note in the code). Add some tests.

[cottrell]

No description provided.

[codecov]

Codecov Report

Merging #820 (478315f) into master (c952c22) will increase coverage by 0.04%.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##           master     #820      +/-   ##
==========================================
+ Coverage   94.44%   94.48%   +0.04%     
==========================================
  Files          47       47              
  Lines        6964     6980      +16     
==========================================
+ Hits         6577     6595      +18     
+ Misses        387      385       -2     

Impacted Files	Coverage Δ
joblib/memory.py	95.37% <77.77%> (-0.19%)	⬇️
joblib/test/test_memory.py	98.58% <100.00%> (+0.02%)	⬆️
joblib/_parallel_backends.py	94.92% <0.00%> (+1.17%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c952c22...478315f. Read the comment docs.

[cottrell]

Code coverage is showing changes in parallel_backends and logger for some reason. No changes there.

[tomMoral]

LGTM up to a typo.

Could you please add an entry in the change log?

[cottrell]

Just pushed the wrong branch in case someone was about to do something here ... fixing in one sec.

[cottrell]

Just pushed the wrong branch in case someone was about to do something here ... fixing in one sec.

Squashed again to one commit. And import removal had crept in and the test had not picked it up. I think the risks are now small as it is only one screen of new lines to view in the single commit.

[aabadie]

It seems to me that this PR is addressing the same problem as #730. Did you have a look at it first ?

[cottrell]

It seems to me that this PR is addressing the same problem as #730. Did you have a look at it first ?

nope. 20 line diff. can't even remember this. Whoever is managing this repo just chuck whatever is easiest. Nobody getting paid here for this so no hard feelings :) as long and the functionality gets in.

[tomMoral]

This PR seems to have stalled. I think this would be useful.
It seems that the only missing parts are an entry in the changelog and a mention in the doc. @cottrell are you available to help getting this merged?

[cottrell]

@tomMoral just saw this ... I've added something to the doc and the changelog. I'm assuming the pipeline does the auto gen part of the doc stuff.

Rebased on master.

[cottrell]

Not sure about those test failures, likely the master I rebased on. I don't think those failures happened before the rebase.

[danlkv]

What happened? Why this is not merged?

[tomMoral]

I did not notice the update from @cottrell , sorry!
Indeed, we should merge this one. I will rebase on master and try to get this merge asap.

[tomMoral]

@aabadie @ogrisel I think this feature is helpful and the proposed solution is nice.
Not so sure about the naming.

[tomMoral]

Some nitpicks.