Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test that ensure conservation of byte order during IPC #1562

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

fcharras
Copy link
Contributor

@fcharras fcharras commented Apr 5, 2024

This test shows that the current behavior regarding byteorder consistency in IPC is fine, and will also show that there's no regression in #1561 .

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@c2087db). Click here to learn what that means.

Files Patch % Lines
joblib/test/test_parallel.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1562   +/-   ##
=======================================
  Coverage        ?   95.15%           
=======================================
  Files           ?       44           
  Lines           ?     7596           
  Branches        ?        0           
=======================================
  Hits            ?     7228           
  Misses          ?      368           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomMoral tomMoral merged commit 1b0d1f4 into main Apr 9, 2024
19 checks passed
@tomMoral tomMoral deleted the MNT/add_byteorder_consistency_test branch April 9, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants